Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.0 - Embeddable, Searchable, Completions, Prompts #1

Merged
merged 38 commits into from
Sep 16, 2024

Conversation

kladaFOX
Copy link
Contributor

@kladaFOX kladaFOX commented Aug 28, 2024

Version 1.0 of Spectre 🚀

@kladaFOX kladaFOX self-assigned this Aug 28, 2024
@kladaFOX kladaFOX requested a review from matthewblack August 30, 2024 15:46
Copy link
Member

@matthewblack matthewblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome dude!

Couple of in-line comments.

README.md Outdated Show resolved Hide resolved
lib/spectre/searchable.rb Outdated Show resolved Hide resolved
kladaFOX and others added 2 commits August 30, 2024 18:29
Co-authored-by: Matthew Black <m@hiremav.com>
@kladaFOX kladaFOX changed the title Embeddable Embeddable, Searchable, Completions, Prompts Sep 4, 2024
@matthewblack matthewblack removed their request for review September 4, 2024 22:39
Copy link
Member

@matthewblack matthewblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of in-line notes.

lib/spectre/prompt.rb Outdated Show resolved Hide resolved
lib/generators/spectre/install_generator.rb Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
lib/spectre/openai/completions.rb Outdated Show resolved Hide resolved
lib/spectre/prompt.rb Show resolved Hide resolved
Copy link
Member

@matthewblack matthewblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay one last thing. After reading the OpenAI API docs, let's also sync up the way they're handling embeddings.

It should be Spectre.provider_module::Embeddings.create("Your text here") vs Spectre.provider_module::Embeddings.generate("Your text here").

I already proofed and updated the README to reflect that change. So once we change that method name we're good to go!

lib/spectre/openai/embeddings.rb Outdated Show resolved Hide resolved
Copy link
Member

@matthewblack matthewblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Let's ship it! 🚀

@matthewblack matthewblack changed the title Embeddable, Searchable, Completions, Prompts Version 1.0 - Embeddable, Searchable, Completions, Prompts Sep 16, 2024
@kladaFOX kladaFOX merged commit a026fc1 into main Sep 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants