-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 1.0 - Embeddable, Searchable, Completions, Prompts #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome dude!
Couple of in-line comments.
Co-authored-by: Matthew Black <m@hiremav.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of in-line notes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay one last thing. After reading the OpenAI API docs, let's also sync up the way they're handling embeddings.
It should be Spectre.provider_module::Embeddings.create("Your text here")
vs Spectre.provider_module::Embeddings.generate("Your text here")
.
I already proofed and updated the README to reflect that change. So once we change that method name we're good to go!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Let's ship it! 🚀
Version 1.0 of Spectre 🚀