fix(v5): wss need two messages to ping

hirokisan · May 8, 2023 · 931bcfe · 931bcfe
1 parent 80f8da7
commit 931bcfe
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/v5_ws_private.go b/v5_ws_private.go
@@ -229,7 +229,12 @@ func (s *V5WebsocketPrivateService) Run() error {
 
 // Ping :
 func (s *V5WebsocketPrivateService) Ping() error {
-	if err := s.writeMessage(websocket.PingMessage, []byte(`{"op":"ping"}`)); err != nil {
+	// NOTE: It appears that two messages need to be sent.
+	// REF: https://github.com/hirokisan/bybit/pull/127#issuecomment-1537479346
+	if err := s.writeMessage(websocket.PingMessage, nil); err != nil {
+		return err
+	}
+	if err := s.writeMessage(websocket.TextMessage, []byte(`{"op":"ping"}`)); err != nil {
 		return err
 	}
 	return nil

diff --git a/v5_ws_public.go b/v5_ws_public.go
@@ -130,6 +130,7 @@ func (s *V5WebsocketPublicService) Start(ctx context.Context, errHandler ErrHand
 	go func() {
 		defer close(done)
 		defer s.connection.Close()
+
 		_ = s.connection.SetReadDeadline(time.Now().Add(60 * time.Second))
 		s.connection.SetPongHandler(func(string) error {
 			_ = s.connection.SetReadDeadline(time.Now().Add(60 * time.Second))
@@ -234,7 +235,12 @@ func (s *V5WebsocketPublicService) Run() error {
 
 // Ping :
 func (s *V5WebsocketPublicService) Ping() error {
-	if err := s.writeMessage(websocket.PingMessage, []byte(`{"op":"ping"}`)); err != nil {
+	// NOTE: It appears that two messages need to be sent.
+	// REF: https://github.com/hirokisan/bybit/pull/127#issuecomment-1537479346
+	if err := s.writeMessage(websocket.PingMessage, nil); err != nil {
+		return err
+	}
+	if err := s.writeMessage(websocket.TextMessage, []byte(`{"op":"ping"}`)); err != nil {
 		return err
 	}
 	return nil