Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #325: Improve support for bundling/importing through vite. #326

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

roelvanhintum
Copy link

  • Updated dependencies
  • Remove exposing to window
  • Externalize all dependencies

@hiukim
Copy link
Owner

hiukim commented Dec 31, 2022

Is it going to break applications that install the library with <script> tag ?

@roelvanhintum
Copy link
Author

@hiukim could be. I did not test using the script tag. I see i messed up with a last commit, which is just there for testing and shouldn’t be in the pull-request.

@jmschrack
Copy link
Contributor

@roelvanhintum
I've noticed you externalized all the dependencies, but you didn't move them to peerDependencies block inside of package.json? Why not? Also, have you tested the examples to make sure they still work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants