Updates for bevel tool #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds coincident constraints if startpoint has an attached reference. Also adds construction lines/arcs to the reference startpoint.
|
This works well! Only thing i found is that when there is a construction arc segment added the coincident constraint is redundant. |
Indeed, updated to only set them on the lines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds coincident constraints if startpoint has an attached reference. Also adds construction lines/arcs to the reference startpoint.
This fixes:
Bevel Tool Supporting Lines For Constrained Points #389
But is dependent on feature "Line distances have been replaced for point to point distances." in PR:
Checks for duplicate constraints. #461