Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Lazy loading instead of Eager to reduce database calls #740

Merged
merged 3 commits into from
Aug 23, 2024

Conversation

Ben-Edwards-cgi
Copy link
Contributor

@Ben-Edwards-cgi Ben-Edwards-cgi commented Aug 23, 2024

Links

Jira
Sonar

Change description

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[X] No

@Ben-Edwards-cgi Ben-Edwards-cgi requested a review from a team as a code owner August 23, 2024 09:07
@Ben-Edwards-cgi Ben-Edwards-cgi changed the base branch from master to Stabilisation13 August 23, 2024 13:56
@Ben-Edwards-cgi Ben-Edwards-cgi merged commit f7eca9a into Stabilisation13 Aug 23, 2024
7 checks passed
@Ben-Edwards-cgi Ben-Edwards-cgi deleted the JM-8052-v2 branch August 23, 2024 13:56
Ben-Edwards-cgi added a commit that referenced this pull request Aug 28, 2024
* Updated Ballot reports to be ordered by juror last name (#730)

* update daily-utilisation-jurors to not fill up a null column if there is no entries for that specific day (#731)

* Fixed issue where attendance and payment history would show the incorrect data (#733)

* Hotfix/jm 8074 (#735)

* hotfix/JM-8074 Technical error when changing the deferral date using the "Change" button on the overview page

* reverting unwanted update for flyway

* Update build.gradle

* Update build.gradle

* updates for PMD and checkstyles

* Update README.md (#574)

* Update README.md

* Update README.md

* Update CreatePoolControllerITest.java

* Use Lazy loading instead of Eager to reduce database calls (#740)

* Updated Many classes to use Lazy Loading

* Removed comment

* Applied review comments

* Updated the way we show the jurors location to only show if they are checked in or on a trial (#745)

* Filtering on service start date on active pool screen only applies to page you filter on (#732)

* Updated pools-requested endpoint to use pagination Utils

* Fixed styles

* Updated active pools to use pagination utils

* Applied review comments

* update filters to add missing and update wrong ones (#743)

* update filters to add missing and update wrong ones

* update how we group-by on active pools filtering

* Fixed styles

---------

Co-authored-by: Ricardo <140706972+ricardofreitasrocha@users.noreply.github.com>

* Added includePanelMembers to person attending summary and detailed reports (#746)

* Fixed tests

* Remove JurorPoolUtils.getSingleActiveJurorPool() and replace with jurorPoolSerive.getActiveRecordFromUser() (#744)

* Updated the way we retrieve juror pools to prevent non-unique entry errors

* Applied review comments

* Fixed styles / merged stabilisation13

* fix_random_fail_test (#747)

* Permission change to allow the Bureau general users to edit change name / fix error in name option (#748)

* Updated permissions needed to fix error in current name

* Applied review comments

* hotfix/JM-8103 update to utilisation report functions (#749)

* hotfix/JM-8103 update to utilisation report functions

* updating tests

* updates following business review

* Added comments to sql file

* Active Pools Not Displaying Records (#750)

* Removed limits for active pool and pool requests

* Fixed styles

* Fixed styles

* Fixed issue where attendance audit number would incorrectly be added

* Fixed issue where attendance audit number would incorrectly be added

* Fixed styles

---------

Co-authored-by: Ricardo <140706972+ricardofreitasrocha@users.noreply.github.com>
Co-authored-by: akikrahman1 <149579836+akikrahman1@users.noreply.github.com>
Co-authored-by: akikrahman1 <akhlaqur.rahman1@hmcts.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants