Juror showing with a room location when they have not yet attended #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…checked in or on a trial
akikrahman1
approved these changes
Aug 23, 2024
Ben-Edwards-cgi
added a commit
that referenced
this pull request
Aug 28, 2024
* Updated Ballot reports to be ordered by juror last name (#730) * update daily-utilisation-jurors to not fill up a null column if there is no entries for that specific day (#731) * Fixed issue where attendance and payment history would show the incorrect data (#733) * Hotfix/jm 8074 (#735) * hotfix/JM-8074 Technical error when changing the deferral date using the "Change" button on the overview page * reverting unwanted update for flyway * Update build.gradle * Update build.gradle * updates for PMD and checkstyles * Update README.md (#574) * Update README.md * Update README.md * Update CreatePoolControllerITest.java * Use Lazy loading instead of Eager to reduce database calls (#740) * Updated Many classes to use Lazy Loading * Removed comment * Applied review comments * Updated the way we show the jurors location to only show if they are checked in or on a trial (#745) * Filtering on service start date on active pool screen only applies to page you filter on (#732) * Updated pools-requested endpoint to use pagination Utils * Fixed styles * Updated active pools to use pagination utils * Applied review comments * update filters to add missing and update wrong ones (#743) * update filters to add missing and update wrong ones * update how we group-by on active pools filtering * Fixed styles --------- Co-authored-by: Ricardo <140706972+ricardofreitasrocha@users.noreply.github.com> * Added includePanelMembers to person attending summary and detailed reports (#746) * Fixed tests * Remove JurorPoolUtils.getSingleActiveJurorPool() and replace with jurorPoolSerive.getActiveRecordFromUser() (#744) * Updated the way we retrieve juror pools to prevent non-unique entry errors * Applied review comments * Fixed styles / merged stabilisation13 * fix_random_fail_test (#747) * Permission change to allow the Bureau general users to edit change name / fix error in name option (#748) * Updated permissions needed to fix error in current name * Applied review comments * hotfix/JM-8103 update to utilisation report functions (#749) * hotfix/JM-8103 update to utilisation report functions * updating tests * updates following business review * Added comments to sql file * Active Pools Not Displaying Records (#750) * Removed limits for active pool and pool requests * Fixed styles * Fixed styles * Fixed issue where attendance audit number would incorrectly be added * Fixed issue where attendance audit number would incorrectly be added * Fixed styles --------- Co-authored-by: Ricardo <140706972+ricardofreitasrocha@users.noreply.github.com> Co-authored-by: akikrahman1 <149579836+akikrahman1@users.noreply.github.com> Co-authored-by: akikrahman1 <akhlaqur.rahman1@hmcts.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links
Change description
we need to update the logic so when a juror is in status juror or panel we always show the room location, but if in status responded we only show the room location if they are checked in.
Does this PR introduce a breaking change? (check one with "x")