Set on_call in the database to be a not null field with a default value of (false) to prevent failures for checks such as .ne(false) #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akikrahman1
approved these changes
Aug 30, 2024
akikrahman1
added a commit
that referenced
this pull request
Sep 9, 2024
* Updated made on call a required field. (#755) * Confirm attendance list is taking into account confirmed but returned trial attendances. This should only show the unconfirmed count. (#753) * Added restrictions to confirm attendance so prevent attendances from being confirmed multiple times. * Fixed tests * History stating jury attendance confirmed when return but do not confirm was selected (#752) * Fixed issue where jury attendance history would get created if you returned the panel but did not confirm attendance * Fixed tests * Added additional scheduler metrics (#575) * Added additional scheduler metrics * Added additional scheduler metrics * Added null or blank check when checking if an email / phone number exists * Minor tidy up * Fixed compile issue * Added validating in for invalid phone numbers or email addresses * Applied review comments * hotfix/JM-8102 fix for missing days (#756) * hotfix/JM-8102 fix for missing days * updated flyway migration name to avoid conflict * hotfix/JM-7928 update to utilisation report query --------- Co-authored-by: Ben Edwards <147524406+Ben-Edwards-cgi@users.noreply.github.com>
akikrahman1
added a commit
that referenced
this pull request
Sep 11, 2024
* Hotfix/jm 7928 (#761) * Updated made on call a required field. (#755) * Confirm attendance list is taking into account confirmed but returned trial attendances. This should only show the unconfirmed count. (#753) * Added restrictions to confirm attendance so prevent attendances from being confirmed multiple times. * Fixed tests * History stating jury attendance confirmed when return but do not confirm was selected (#752) * Fixed issue where jury attendance history would get created if you returned the panel but did not confirm attendance * Fixed tests * Added additional scheduler metrics (#575) * Added additional scheduler metrics * Added additional scheduler metrics * Added null or blank check when checking if an email / phone number exists * Minor tidy up * Fixed compile issue * Added validating in for invalid phone numbers or email addresses * Applied review comments * hotfix/JM-8102 fix for missing days (#756) * hotfix/JM-8102 fix for missing days * updated flyway migration name to avoid conflict * hotfix/JM-7928 update to utilisation report query --------- Co-authored-by: Ben Edwards <147524406+Ben-Edwards-cgi@users.noreply.github.com> * Hotfix/jm 8102 (#760) * hotfix/JM-8102 fix for missing days * updated flyway migration name to avoid conflict * Revert "Hotfix/jm 7928 (#761)" This reverts commit 2c0c871. * interim1 release candidate changes only * Update DailyUtilisationReportsITest_typical.sql * Update DailyUtilisationReportsITest_typical.sql --------- Co-authored-by: Ben Edwards <147524406+Ben-Edwards-cgi@users.noreply.github.com>
akikrahman1
added a commit
that referenced
this pull request
Sep 26, 2024
* Updated made on call a required field. (#755) * Confirm attendance list is taking into account confirmed but returned trial attendances. This should only show the unconfirmed count. (#753) * Added restrictions to confirm attendance so prevent attendances from being confirmed multiple times. * Fixed tests * History stating jury attendance confirmed when return but do not confirm was selected (#752) * Fixed issue where jury attendance history would get created if you returned the panel but did not confirm attendance * Fixed tests * Added additional scheduler metrics (#575) * Added additional scheduler metrics * Added additional scheduler metrics * Added null or blank check when checking if an email / phone number exists * Minor tidy up * Fixed compile issue * Added validating in for invalid phone numbers or email addresses * Applied review comments * hotfix/JM-8102 fix for missing days (#756) * hotfix/JM-8102 fix for missing days * updated flyway migration name to avoid conflict * hotfix/JM-7928 update to utilisation report query (#758) * Updated electronic police check report header (#759) * Update V2_30__util_report_update.sql * Update V2_31__util_report_update.sql * renaming flyway migration to avoid sequence error on deployments * Feature/JM-8190 (#765) * task/JM-8193 (#763) * Task/JM-8191 Manually create a juror record (#764) * task/JM-8191 * task/JM-8191 * updates for test fix and styles * adding unit test * updated tests * Update JurorRecordServiceTest.java * Update JurorRecordControllerITest.java * JM-8196 Amend PNC View (#767) * Feature/jm 8181 (#768) * JM-8196 Amend PNC View * JM-8196 Amend PNC View * JM-8196 Amend PNC View * JM-8196 Amend PNC View remove spaces last_name * remove duplicate migration file * Task/JM-8188 Pre-mod userids preventing access to digital response records (#769) * task/JM-8188 Unable to view migrated digital responses * fixed checkStyle issue * JM-8196 Amend PNC View remove spaces last_name (#770) * cleared empty space * removing redundant spaces to make files same as interim1 --------- Co-authored-by: Ben Edwards <147524406+Ben-Edwards-cgi@users.noreply.github.com> Co-authored-by: Callum Young <148960132+callum-r-young@users.noreply.github.com> Co-authored-by: EPatterson1 <140503822+EPatterson1@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links
Change description
Does this PR introduce a breaking change? (check one with "x")