HMA 6727 change link visibility (#116)

* HMA-6727 action button visibility fixes * HMA-6727 further action button visibility changes * HMA-6727 further action button visibility changes
hmrc · Mar 29, 2023 · ae5fb5b · ae5fb5b
1 parent 84346da
commit ae5fb5b
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -16,6 +16,10 @@ Allowed headings:
 
 ## [Unreleased]
 
+### Fixed
+
+* `EditableListView` further action button visibility fixes.
+
 ## [4.5.4] - 2023-03-27
 
 ### Fixed

diff --git a/components/src/main/java/uk/gov/hmrc/components/organism/editable/EditableListViewAdapter.kt b/components/src/main/java/uk/gov/hmrc/components/organism/editable/EditableListViewAdapter.kt
@@ -17,6 +17,7 @@ package uk.gov.hmrc.components.organism.editable
 
 import android.annotation.SuppressLint
 import android.view.LayoutInflater
+import android.view.View
 import android.view.ViewGroup
 import androidx.core.view.isVisible
 import androidx.recyclerview.widget.RecyclerView
@@ -91,7 +92,7 @@ class EditableListViewAdapter : RecyclerView.Adapter<EditableListViewAdapter.Vie
             } else {
                 itemView.isClickable = false
                 actionButton.isClickable = false
-                actionButton.isVisible = false
+                actionButton.visibility = View.INVISIBLE
                 motionLayout.transitionToStart()
             }
         }

diff --git a/components/src/main/res/layout/editable_list_items.xml b/components/src/main/res/layout/editable_list_items.xml
@@ -34,7 +34,8 @@
         android:minHeight="0dp"
         android:importantForAccessibility="no"
         android:layout_width="wrap_content"
-        android:layout_height="wrap_content" />
+        android:layout_height="wrap_content"
+        android:visibility="invisible" />
 
     <View
         android:id="@+id/divider"

diff --git a/components/src/main/res/xml/scene_editing_mode.xml b/components/src/main/res/xml/scene_editing_mode.xml
@@ -51,7 +51,8 @@
             motion:layout_constraintWidth_max="120dp"
             motion:layout_constraintBottom_toBottomOf="parent"
             motion:layout_constraintEnd_toEndOf="parent"
-            motion:layout_constraintTop_toTopOf="parent" />
+            motion:layout_constraintTop_toTopOf="parent"
+            motion:visibilityMode="ignore" />
 
         <androidx.constraintlayout.widget.Barrier
             android:id="@+id/barrier"
@@ -100,7 +101,8 @@
             motion:layout_constraintWidth_max="120dp"
             motion:layout_constraintBottom_toBottomOf="parent"
             motion:layout_constraintEnd_toEndOf="parent"
-            motion:layout_constraintTop_toTopOf="parent" />
+            motion:layout_constraintTop_toTopOf="parent"
+            motion:visibilityMode="ignore" />
 
         <androidx.constraintlayout.widget.Barrier
             android:id="@id/barrier"