Fix conditional logic for string length checks (#59)

Corrected the conditional checks for 'parentDisplay', 'parentName', and 'description' in the MetadataResultSetUtil class. This ensures that non-empty strings are returned appropriately, enhancing the accuracy of metadata retrieval.
hms-dbmi · Nov 21, 2024 · 895525d · 895525d
1 parent 60d3904
commit 895525d
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/main/java/edu/harvard/dbmi/avillach/dictionary/legacysearch/MetadataResultSetUtil.java b/src/main/java/edu/harvard/dbmi/avillach/dictionary/legacysearch/MetadataResultSetUtil.java
@@ -96,14 +96,14 @@ private static String bytesToHex(byte[] hash) {
     }
 
     private String getParentDisplay(ResultSet rs) throws SQLException {
-        return StringUtils.hasLength("parentDisplay") ? "" : rs.getString("parentDisplay");
+        return StringUtils.hasLength("parentDisplay") ? rs.getString("parentDisplay") : "";
     }
 
     private String getParentName(ResultSet rs) throws SQLException {
-        return StringUtils.hasLength(rs.getString("parentName")) ? "All Variables" : rs.getString("parentName");
+        return StringUtils.hasLength(rs.getString("parentName")) ? rs.getString("parentName") : "All Variables";
     }
 
     private String getDescription(ResultSet rs) throws SQLException {
-        return StringUtils.hasLength(rs.getString("description")) ? "" : rs.getString("description");
+        return StringUtils.hasLength(rs.getString("description")) ? rs.getString("description") : "";
     }
 }