-
-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#701 Improve note support : WYSIWYG markdown #715
base: main
Are you sure you want to change the base?
#701 Improve note support : WYSIWYG markdown #715
Conversation
08c27a7
to
64120fc
Compare
This is a first implementation, I will keep it simple for the moment. here's a full implementation example : https://playground.lexical.dev/?showTreeView=false&isAutocomplete=true Let me know if everything all right in the PR. |
0400ae9
to
b687d6f
Compare
Added useTranslation to all string |
First implementation with a wysiwyg markdown editor. Update: - Add Lexical markdown editor - consistent rendering between card and preview - removed edit modal, replaced by preview with save action - simple markdown shortcut: underline, bold, italic etc...
b687d6f
to
19f0427
Compare
improved performance to not rerender all note card when one is updated
812abbc
to
e3bc06d
Compare
Ok, I spent a lot of time today reading about lexical and understanding how it works. It's pretty cool and thanks for introducing it into the codebase. I've pushed a bunch of modifications/fixes to the PR that I hope you don't mind:
Now, to merge this PR. There's a couple of things that we need to do:
|
Hello, Thank for your feedback and review.
You're right.
No problem, I understand.
Yes, I will add a little tooltip helper so
Yes, it bother me too, I didn't know how we can find a way around it.
Why not, I have no opinion on that.
Definitely yes, you can see a button in the lexical playground here |
Hello,
Todo ?
|
…escape a list with enter + enter - added codeblock plugin - added prose dark:prose-invert prose-p:m-0 like you said (there's room for improvement I think, don't took the time too deep dive in) and removed theme - Added a switch to show raw markdown - Added back the react markdown for card (SSR)
First implementation with a wysiwyg markdown editor. Update: