Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: onInit and onRender are always called with the instance #2129

Merged
merged 1 commit into from
Nov 2, 2023
Merged

fix: onInit and onRender are always called with the instance #2129

merged 1 commit into from
Nov 2, 2023

Conversation

tjallingt
Copy link
Contributor

Description

The type declaration for the KeyboardOptions seems inaccurate, onInit and onRender are always called with an instance of SimpleKeyboard.

Checks

  • Tests ( npm run test -- --coverage ) Coverage at ./coverage/lcov-report/index.html should be 100%

@hodgef hodgef merged commit 26220c4 into hodgef:master Nov 2, 2023
2 checks passed
@hodgef hodgef self-assigned this Nov 2, 2023
@hodgef hodgef added the 💥 Bug Something isn't working label Nov 2, 2023
@hodgef
Copy link
Owner

hodgef commented Nov 2, 2023

Thank you @tjallingt ! Much appreciated

@tjallingt tjallingt deleted the patch-1 branch January 4, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hodgef hodgef

Labels
💥 Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tjallingt @hodgef