fix(except): special treatment for string

hogiagroup · Dec 2, 2021 · 86faca3 · 86faca3
1 parent 7d46f15
commit 86faca3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/enumerable.ts b/src/enumerable.ts
@@ -477,7 +477,7 @@ export class Enumerable<T> implements Iterable<T> {
    */
   public except(iterable: Iterable<T>): this;
   @parse((_thisRef: Enumerable<T>, itemOrIterable: T | Iterable<T>) => {
-    if (!Utils.isIterable(itemOrIterable)) {
+    if (!Utils.isIterable(itemOrIterable) || typeof itemOrIterable === 'string') {
       return [(x: T) => x !== itemOrIterable];
     }
     const set = new Set(itemOrIterable as Iterable<T>);

diff --git a/src/test/enumerable.spec.ts b/src/test/enumerable.spec.ts
@@ -1256,8 +1256,8 @@ describe('Enumerable', () => {
       expect(new Enumerable([1, 2, 3]).except(0).toArray()).toEqual([1, 2, 3]);
 
       jsc.assertForall(
-        jsc.array(jsc.nat), jsc.nat,
-        (xs: number[], a: number) =>
+        jsc.array(jsc.string), jsc.string,
+        (xs: string[], a: string) =>
           !new Enumerable(xs).except(a).contains(a)
       );
     });