pass batch down to sign and verify function #413
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chm-diederichs
force-pushed
the
batch-auth
branch
3 times, most recently
from
bbb71c6
to
58edb1e
Compare
|
Corestore will stop working due the breaking changes, should we make it backward compatible or update Corestore accordingly? |
LuKks
reviewed
Aug 11, 2023
chm-diederichs
force-pushed
the
batch-auth
branch
from
58edb1e
to
e755051
Compare
Updated the PR to be backwards compat, now |
|
Cool, last thing I think we can safely remove this unused helper now Line 26 in 3589b2d |
|
These changes we need were merged in #418. Now this PR would just be removing the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.