rocksdb: only create single read batch in bg call #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HDegroote
reviewed
Oct 4, 2024
lib/replicator.js
Outdated
| const reader = this.core.storage.createReadBatch() | ||
| reader.tryFlush() | ||
|
|
||
| for (const b of this._blocks) { |
There was a problem hiding this comment.
Sanity check: this shouldn't be for (const b of blocks) { ? Otherwise it's iterating over a data structure than can mutate during iteration, so line 1854 can have pretty strange behaviour if the entry doesn't exist.
HDegroote
reviewed
Oct 4, 2024
lib/replicator.js
Outdated
| for (const b of this._blocks) { | ||
| if (this.core.bitfield.get(b.index) === false) continue | ||
| blocks.set(b.index, this.core.blocks.get(reader, b.index)) |
There was a problem hiding this comment.
Sanity check: this.core.blocks.get(reader, b.index) can never reject? Otherwise I think it needs a safetyCatch or noop catch-handler, since there are async operations before the promises are awaited
HDegroote
approved these changes
Oct 4, 2024
chm-diederichs
force-pushed
the
rocksdb-batch-resolve
branch
from
f7fa008
to
ddcd823
Compare
mafintosh
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.