Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instructions on getting a specific holonix version #421

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

pdaoust
Copy link
Collaborator

@pdaoust pdaoust commented Feb 2, 2024

(plus a capitalisation fix)

Copy link
Member

@steveej steveej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@steveej steveej self-requested a review February 3, 2024 09:28
steveej
steveej previously requested changes Feb 3, 2024
Copy link
Member

@steveej steveej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

ops, i was too quick. i realize now that the context of these commands are not in a checkout of the holochain repository. hence, the version paths which assume that won't work in any other case. solutions are either make that context explicit or give absolute URLs to github.

src/pages/get-started/install-advanced.md Outdated Show resolved Hide resolved
src/pages/get-started/install-advanced.md Outdated Show resolved Hide resolved
src/pages/get-started/install-advanced.md Outdated Show resolved Hide resolved
@pdaoust
Copy link
Collaborator Author

pdaoust commented Feb 8, 2024

Darn, I was hoping nix was more magical than that. (thanks @ThetaSinner for catching the complete absence of github:holochain/holochain in my commands; don't know how that slipped past me. Must've copy/pasted the nearest command w/o paying attention.)

@ThetaSinner
Copy link
Member

It's open source, any magic you feel is missing can be added. You could create a version that always assumes relative paths point to Holochain :) But yeah, it's simpler to reference derivations from inside the repo than from outside unfortunately. Nothing too crazy syntax-wise at least, just some long commands.

Something else it would be good to document somewhere at some point is an answer to the questions "You modified Holochain for me, how do I run that from your branch?" and "You modified the HDK for me, how do I use that in my happs before you merge your changes". These are questions I've had several times, and the answer is often "The change is going into develop so you need a happ based on 0.3.x to be able to use it" but it does happen that people running on 0.3.x would be happy to test things, but it's not obvious how to do it. So when I say we should document it, what I actually mean is that somebody should push figuring out how to the top of my priority list so we can document it 😁

src/pages/get-started/install-advanced.md Outdated Show resolved Hide resolved
src/pages/get-started/install-advanced.md Outdated Show resolved Hide resolved
@ThetaSinner
Copy link
Member

@pdaoust Do you have what you need from me to finish this off? I'd love to see this deployed so I can point people at it :)

@pdaoust
Copy link
Collaborator Author

pdaoust commented Feb 22, 2024

@ThetaSinner I do, thanks -- I'm going to change the examples to reflect that 0.2 is the default now though.

Co-authored-by: ThetaSinner <ThetaSinner@users.noreply.github.com>
@pdaoust pdaoust dismissed steveej’s stale review February 22, 2024 18:51

Gregory made Stefan's requested changes for me.

@pdaoust pdaoust merged commit 49e3865 into main Feb 22, 2024
5 checks passed
@pdaoust pdaoust deleted the 2024-02-02-ad-hoc-shell-choose-your-own-version branch February 22, 2024 18:51
@pdaoust pdaoust restored the 2024-02-02-ad-hoc-shell-choose-your-own-version branch February 22, 2024 18:51
@pdaoust pdaoust deleted the 2024-02-02-ad-hoc-shell-choose-your-own-version branch February 22, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants