Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Design System from Site Search and updated Pagefind lib #428

Merged
merged 4 commits into from
Feb 27, 2024

Conversation

MatthewNichols
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@pdaoust pdaoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I know enough about Pagefind and the site structure to know 100% whether this PR is okay, so I'm gonna trust your wisdom on that @MatthewNichols ! :D I'm guessing the design system files don't use src/pages/_includes/base-layout.njk and are therefore not indexed?

@MatthewNichols
Copy link
Collaborator Author

I don't think I know enough about Pagefind and the site structure to know 100% whether this PR is okay, so I'm gonna trust your wisdom on that @MatthewNichols ! :D I'm guessing the design system files don't use src/pages/_includes/base-layout.njk and are therefore not indexed?

That is correct. I added a section to the ReadMe that goes into it a little, and points to the documentation for more in-depth.

@MatthewNichols MatthewNichols merged commit 9ad3945 into main Feb 27, 2024
6 checks passed
@MatthewNichols MatthewNichols deleted the feb-23-fixing-search-index branch February 27, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants