Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Holonix upgrade guide #465

Merged
merged 7 commits into from
Oct 11, 2024
Merged

Conversation

pdaoust
Copy link
Collaborator

@pdaoust pdaoust commented Oct 3, 2024

No description provided.

Copy link
Contributor

@jost-s jost-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy to follow and understand, I think.

The sections after "Upgrade an existing project" are similar to the README in the Holonix repro. I prefer to link to that README from here or add multiple links to anchors on that README instead. If you think there should be something added/clarified there, I'd be delighted about a PR there.

src/pages/resources/upgrade/upgrade-new-holonix.md Outdated Show resolved Hide resolved
src/pages/resources/upgrade/upgrade-new-holonix.md Outdated Show resolved Hide resolved
src/pages/resources/upgrade/upgrade-new-holonix.md Outdated Show resolved Hide resolved
jost-s and others added 2 commits October 8, 2024 20:50
Co-authored-by: Jost Schulte <jost.schulte@protonmail.com>
@pdaoust
Copy link
Collaborator Author

pdaoust commented Oct 11, 2024

@jost-s

I prefer to link to that README from here or add multiple links to anchors on that README instead.

sounds like a good idea; I'll do that.

@pdaoust pdaoust merged commit 188a5e1 into main Oct 11, 2024
6 checks passed
@pdaoust pdaoust deleted the 2024-09-30-new-holonix-upgrade-guide branch October 11, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants