-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce nixpkgsNix, set nix version to 2.20; chore: bump nix-darwin and fix darwin deploy script #92
Conversation
Seems ok to me. But I'm not much in favour of having multiple nixpkgs instances. 24.05 will be released in two weeks and will contain this nix version, so if we merge this, I would propose to update to 24.05 as soon as possible and get rid of the separate nixpkgs instance again. |
so there are no foreseeable side-effects of upgrading nix to v2.20 on the darwin machines that are used as builders by Holo's hydra instance? |
Barring any bugs, the nix builder protocol is versioned, so it's usually fine to have different versions of the daemons talk with each other. I couldn't look through the code a lot from my phone, are we upgrading nix on the Mac builders but not on hydra? Because they are managed by different repos? |
yes, that's the case. |
based on this i'm going ahead with the update on those builders. |
deployed to
macos-01currently brokenpostponing due to unavailability:
postponing these until #68 is resolved. these are not involved with the holochain CI nix builds, thus they only need nix to build their own system derivation.
potentially fixes holochain/holochain#3556.
Footnotes
could only get to 2.19 at first as 2.20 would show:
error: 'show-config' is a deprecated alias for 'config show'
. was held back by the lack of flake(inputs/nix-darwin): use upstream instead of fork #91 until i rebased that in 11db2c4. ↩ ↩2@peeech @alastairong any contraindications for deploying this on our shared darwin machines? ↩ ↩2