tx5 ep3 integration of endpoint/connection state management refactor #3287
Conversation
neonphog
changed the title
| @@ -7,6 +7,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). | |||
|
|
|||
| ## \[Unreleased\] | |||
|
|
|||
| - *BREAKING* Updates tx5 to a version using new endpoint state logic and a new incompatible protocol. [\#3287](https://github.com/holochain/holochain/pull/3287) | |||
There was a problem hiding this comment.
👍🏻 Is there going to be a back-port for this or is this just on 0.3?
There was a problem hiding this comment.
The plan right now is just on 0.3.
| @@ -120,6 +121,7 @@ impl KitsuneTestHarness { | |||
| self.legacy_host_api.drain_events().await | |||
| } | |||
|
|
|||
| #[allow(dead_code)] | |||
There was a problem hiding this comment.
Sorry yes, this is commented in the tests at the moment because they need more work. Thanks for cleaning up the warnings
| match evt { | ||
| tx5::EpEvt::Connected { rem_cli_url } => { | ||
| tx5::Ep3Event::Error(err) => { | ||
| panic!("Fatal tx5 error: {err:?}"); |
There was a problem hiding this comment.
While Holochain is becoming less network dependent, can Holochain continue functioning with local only data despite this failure?
There was a problem hiding this comment.
not while it's a panic : )
There was a problem hiding this comment.
I just double checked the code, this can only happen in the case of a code mistake, so it is correct to fail fast and let us know something was written incorrectly.
There was a problem hiding this comment.
I changed my mind. I switched it to a tracing error after all: 63250c9
There was a problem hiding this comment.
I don't think it's possible to say a transient error will never in the future be introduced into this path... It would be a problem if some naive change in the future makes it so conductors crash every time a connection drops or something.
Summary
TODO: