Skip to content

Commit

Permalink
Remove deny warnings (#126)
Browse files Browse the repository at this point in the history
* Remove deny warnings

* Bump versions

* Elevate warnings to errors for clippy on CI
  • Loading branch information
ThetaSinner authored Jan 29, 2024
1 parent 2048dd7 commit b11e65e
Show file tree
Hide file tree
Showing 16 changed files with 26 additions and 29 deletions.
6 changes: 3 additions & 3 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ release: tools

static: tools docs
cargo fmt -- --check
cargo clippy $(FEATURES)
cargo clippy $(FEATURES) -- -Dwarnings

docs: tools
printf '### `lair-keystore --help`\n```text\n' > crates/lair_keystore/src/docs/help.md.tmp
Expand Down
10 changes: 5 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ License: MIT OR Apache-2.0

### `lair-keystore --help`
```text
lair_keystore 0.4.1
lair_keystore 0.4.2
secret lair private keystore
USAGE:
Expand Down Expand Up @@ -74,7 +74,7 @@ SUBCOMMANDS:
```
### `lair-keystore init --help`
```text
lair-keystore-init 0.4.1
lair-keystore-init 0.4.2
Set up a new lair private keystore.
USAGE:
Expand All @@ -92,7 +92,7 @@ FLAGS:
```
### `lair-keystore url --help`
```text
lair-keystore-url 0.4.1
lair-keystore-url 0.4.2
Print the connection_url for a configured lair-keystore
server to stdout and exit.
Expand All @@ -106,7 +106,7 @@ FLAGS:
```
### `lair-keystore import-seed --help`
```text
lair-keystore-import-seed 0.4.1
lair-keystore-import-seed 0.4.2
Load a seed bundle into this lair-keystore instance.
Note, this operation requires capturing the pid_file,
make sure you do not have a lair-server running.
Expand Down Expand Up @@ -143,7 +143,7 @@ ARGS:
```
### `lair-keystore server --help`
```text
lair-keystore-server 0.4.1
lair-keystore-server 0.4.2
Run a lair keystore server instance. Note you must
have initialized a config file first with
'lair-keystore init'.
Expand Down
2 changes: 1 addition & 1 deletion crates/hc_seed_bundle/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "hc_seed_bundle"
version = "0.2.0"
version = "0.2.1"
description = "SeedBundle parsing and generation library."
license = "MIT OR Apache-2.0"
repository = "https://github.com/holochain/lair"
Expand Down
2 changes: 1 addition & 1 deletion crates/hc_seed_bundle/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
#![allow(clippy::new_without_default)]
#![deny(missing_docs)]
#![deny(unsafe_code)]
#![deny(warnings)]

//! SeedBundle parsing and generation library.
//!
//! [![Project](https://img.shields.io/badge/project-holochain-blue.svg?style=flat-square)](http://holochain.org/)
Expand Down
6 changes: 3 additions & 3 deletions crates/lair_keystore/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "lair_keystore"
version = "0.4.1"
version = "0.4.2"
description = "secret lair private keystore"
license = "MIT OR Apache-2.0"
repository = "https://github.com/holochain/lair"
Expand All @@ -19,15 +19,15 @@ rusqlite-sqlcipher = [ "rusqlite/sqlcipher" ]

[dependencies]
# lair_keystore_api must be pinned to enable strict version checks
lair_keystore_api = { version = "=0.4.1", path = "../lair_keystore_api" }
lair_keystore_api = { version = "=0.4.2", path = "../lair_keystore_api" }
rpassword = "7.2.0"
rusqlite = { version = "0.29", features = [ "modern_sqlite" ] }
structopt = "0.3.26"
sysinfo = "0.28.4"
tracing-subscriber = { version = "0.3.17", features = [ "env-filter" ] }

[build-dependencies]
lair_keystore_api = { version = "0.4.1", path = "../lair_keystore_api" }
lair_keystore_api = { version = "0.4.2", path = "../lair_keystore_api" }
pretty_assertions = "1.3.0"
sqlformat = "0.2.1"

Expand Down
10 changes: 5 additions & 5 deletions crates/lair_keystore/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ License: MIT OR Apache-2.0

### `lair-keystore --help`
```text
lair_keystore 0.4.1
lair_keystore 0.4.2
secret lair private keystore
USAGE:
Expand Down Expand Up @@ -74,7 +74,7 @@ SUBCOMMANDS:
```
### `lair-keystore init --help`
```text
lair-keystore-init 0.4.1
lair-keystore-init 0.4.2
Set up a new lair private keystore.
USAGE:
Expand All @@ -92,7 +92,7 @@ FLAGS:
```
### `lair-keystore url --help`
```text
lair-keystore-url 0.4.1
lair-keystore-url 0.4.2
Print the connection_url for a configured lair-keystore
server to stdout and exit.
Expand All @@ -106,7 +106,7 @@ FLAGS:
```
### `lair-keystore import-seed --help`
```text
lair-keystore-import-seed 0.4.1
lair-keystore-import-seed 0.4.2
Load a seed bundle into this lair-keystore instance.
Note, this operation requires capturing the pid_file,
make sure you do not have a lair-server running.
Expand Down Expand Up @@ -143,7 +143,7 @@ ARGS:
```
### `lair-keystore server --help`
```text
lair-keystore-server 0.4.1
lair-keystore-server 0.4.2
Run a lair keystore server instance. Note you must
have initialized a config file first with
'lair-keystore init'.
Expand Down
1 change: 0 additions & 1 deletion crates/lair_keystore/src/bin/lair-keystore-bin/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
#![allow(clippy::new_without_default)]
#![deny(missing_docs)]
#![deny(unsafe_code)]
#![deny(warnings)]

//! sqlite/sqlcipher backed LairKeystore server control binary

Expand Down
2 changes: 1 addition & 1 deletion crates/lair_keystore/src/docs/help.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
### `lair-keystore --help`
```text
lair_keystore 0.4.1
lair_keystore 0.4.2
secret lair private keystore
USAGE:
Expand Down
2 changes: 1 addition & 1 deletion crates/lair_keystore/src/docs/import-seed-help.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
### `lair-keystore import-seed --help`
```text
lair-keystore-import-seed 0.4.1
lair-keystore-import-seed 0.4.2
Load a seed bundle into this lair-keystore instance.
Note, this operation requires capturing the pid_file,
make sure you do not have a lair-server running.
Expand Down
2 changes: 1 addition & 1 deletion crates/lair_keystore/src/docs/init-help.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
### `lair-keystore init --help`
```text
lair-keystore-init 0.4.1
lair-keystore-init 0.4.2
Set up a new lair private keystore.
USAGE:
Expand Down
2 changes: 1 addition & 1 deletion crates/lair_keystore/src/docs/server-help.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
### `lair-keystore server --help`
```text
lair-keystore-server 0.4.1
lair-keystore-server 0.4.2
Run a lair keystore server instance. Note you must
have initialized a config file first with
'lair-keystore init'.
Expand Down
2 changes: 1 addition & 1 deletion crates/lair_keystore/src/docs/url-help.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
### `lair-keystore url --help`
```text
lair-keystore-url 0.4.1
lair-keystore-url 0.4.2
Print the connection_url for a configured lair-keystore
server to stdout and exit.
Expand Down
1 change: 0 additions & 1 deletion crates/lair_keystore/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
#![allow(clippy::new_without_default)]
#![deny(missing_docs)]
#![deny(unsafe_code)]
#![deny(warnings)]

//! Secret lair private keystore
//!
Expand Down
4 changes: 2 additions & 2 deletions crates/lair_keystore_api/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "lair_keystore_api"
version = "0.4.1"
version = "0.4.2"
description = "secret lair private keystore API library"
license = "MIT OR Apache-2.0"
repository = "https://github.com/holochain/lair"
Expand All @@ -15,7 +15,7 @@ base64 = "0.13.1"
dunce = "1.0.4"
# this doesn't strictly need to be pinned, but it supports the
# determinism of the strict client/server version checks
hc_seed_bundle = { version = "=0.2.0", path = "../hc_seed_bundle" }
hc_seed_bundle = { version = "=0.2.1", path = "../hc_seed_bundle" }
lru = "0.10.0"
nanoid = "0.4.0"
once_cell = "1.17.1"
Expand Down
1 change: 0 additions & 1 deletion crates/lair_keystore_api/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
#![allow(clippy::new_without_default)]
#![deny(missing_docs)]
#![deny(unsafe_code)]
#![deny(warnings)]

//! Secret lair private keystore API library.
//!
Expand Down

0 comments on commit b11e65e

Please sign in to comment.