-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically migrate unencrypted databases on request #121
Conversation
Waiting for a new version of sodoken holochain/sodoken#22 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. It's too bad sqlcipher didn't do a vacuum into integration VACUUM INTO bla AS ENCRYPTED KEY bla
.
That would be more streamlined! I've got the build for windows working by fetching the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I'm happy with this solution. Thanks @ThetaSinner !
This is similar to the change I made here.
I know that Lair databases are meant to be encrypted but the
lair_keystore
crate exposes the option to disable database encryption by not using default features, so it would be good if there was a way to migrate if you end up being forcibly switched by something that has embedded Lair and changed it's defaults. Looking at you Holochain :)