Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: ThetaSinner <ThetaSinner@users.noreply.github.com>
  • Loading branch information
neonphog and ThetaSinner authored Apr 22, 2024
1 parent ae4d0bc commit 161dba7
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion rust/sbd-client/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ enum MsgType<'t> {

/// A message received from a remote.
/// This is just a single buffer. The first 32 bytes are the public key
/// of the sender. Any remaining bytes are the message. The buffer
/// of the sender, or 28 `0`s followed by a 4 byte command. Any remaining bytes are the message. The buffer
/// contained in this type is guaranteed to be at least 32 bytes long.
pub struct Msg(pub Vec<u8>);

Expand Down
2 changes: 1 addition & 1 deletion rust/sbd-client/src/raw_client.rs
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ fn priv_system_tls(
for cert in rustls_native_certs::load_native_certs()
.expect("failed to load system tls certs")
{
roots.add(cert).expect("faild to add cert to root");
roots.add(cert).expect("failed to add cert to root");
}

if danger_disable_certificate_check {
Expand Down
2 changes: 1 addition & 1 deletion spec.md
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ the first 32 bytes will be altered to represent the peer from which the message

#### 3.2.3. Flow

- The server MUST send `areq` with a random nonce once for every new opened connection.
- The server MUST send `areq` with a random nonce once for every newly opened connection.
The server MAY send any limit messages before or after this `areq`, but it MUST come before the `srdy`.
- The client MUST respond with a signature over the nonce by the private key associated with the public key
sent in the url path segment websocket request
Expand Down

0 comments on commit 161dba7

Please sign in to comment.