Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enhance custom template generation #404

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

c12i
Copy link
Collaborator

@c12i c12i commented Oct 28, 2024

This PR replaces the separate custom-template with a system that builds custom templates from existing template bases (vue, svelte, lit, react, headless).

Changes

  • Removed standalone custom-template
  • Added ability to use existing templates as bases for custom templates
  • Shifted from nix flake init to CLI-based template generation

Benefits

  • Greater flexibility: Developers can now choose from multiple starting points (vue, svelte, lit, react, headless)
  • Reduced maintenance: Eliminates need to maintain a separate custom template
  • Less code duplication: Leverages existing template code

Trade-offs

  • Deprecates nix flake init -t github:holochain/scaffolding workflow
  • Requires using CLI directly to generate custom template base i.e nix run github:holochain/scaffolding#hc-scaffold -- template new or hc-scaffold template new if installed via cargo

Rationale

The increased flexibility and reduced maintenance overhead outweigh the loss of the nix flake init workflow, as developers gain access to multiple template starting points instead of being limited to the previous lit-based custom template.

TODOs

  • Generate custom templates via CLI
  • Update custom template documentation

Closes #388

@c12i c12i marked this pull request as draft October 28, 2024 11:10
@c12i c12i changed the title feat: Add a new template subcommand to create new custom template bases from existing templates feat: Enhance custom template generation Oct 28, 2024
@c12i c12i force-pushed the feat/add-template-new-template-subcommand branch from 5c7d20b to 05bbdad Compare October 28, 2024 14:37
@c12i c12i marked this pull request as ready for review October 28, 2024 14:42
@c12i c12i requested a review from matthme October 28, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant