code review comment

holochain · Feb 2, 2024 · 6cc8ace · 6cc8ace
1 parent 84c519c
commit 6cc8ace
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/crates/tx5-go-pion/src/data_chan.rs b/crates/tx5-go-pion/src/data_chan.rs
@@ -149,10 +149,14 @@ impl DataChannel {
 
         {
             let mut lock = self.0.lock().unwrap();
+            let mut do_swap = false;
             if let Ok(core) = &mut *lock {
                 core.close(err);
+                do_swap = true;
+            }
+            if do_swap {
+                std::mem::swap(&mut *lock, &mut tmp);
             }
-            std::mem::swap(&mut *lock, &mut tmp);
         }
 
         // make sure the above lock is released before this is dropped

diff --git a/crates/tx5-go-pion/src/peer_con.rs b/crates/tx5-go-pion/src/peer_con.rs
@@ -226,10 +226,14 @@ impl PeerConnection {
 
         {
             let mut lock = self.0.lock().unwrap();
+            let mut do_swap = false;
             if let Ok(core) = &mut *lock {
                 core.close(err.clone());
+                do_swap = true;
+            }
+            if do_swap {
+                std::mem::swap(&mut *lock, &mut tmp);
             }
-            std::mem::swap(&mut *lock, &mut tmp);
         }
 
         // make sure the above lock is released before this is dropped