Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mem backend for tx5 #106

Merged
merged 11 commits into from
Oct 16, 2024
Merged

mem backend for tx5 #106

merged 11 commits into from
Oct 16, 2024

Conversation

neonphog
Copy link
Collaborator

No description provided.

@maackle
Copy link
Member

maackle commented Oct 10, 2024

sweet, perhaps we can use this to finish up the tx2 removal in holochain?

@neonphog neonphog self-assigned this Oct 11, 2024
Base automatically changed from abstract-backend to main October 14, 2024 19:54
@neonphog neonphog marked this pull request as ready for review October 14, 2024 22:47
Copy link
Contributor

@cdunster cdunster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments

Comment on lines 4 to 13
/*
* Mem backend timings. The hope is to have near ideal zero overhead.
* At time of writing, you can see we're pretty close to exactly
* proportional to node count for a given machine's resources:
*
* - 1 nodes, 33941 ops, 0.000028 sec/op, in 1.004478s
* - 10 nodes, 174041 ops, 0.000056 sec/op, in 1.016977s
* - 100 nodes, 175111 ops, 0.000580 sec/op, in 1.018943s
* - 1000 nodes, 160266 ops, 0.006361 sec/op, in 1.019859s
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be a file-level comment block with //! at the top?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, good call. done: 1887abd

Comment on lines +103 to +104
// in base64 a string of 0xb7 renders as `t7e3t7e3t...`
// which sort-of looks like "test" if you squint : )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆

crates/tx5/src/backend/mem.rs Outdated Show resolved Hide resolved
crates/tx5/src/backend/mem.rs Outdated Show resolved Hide resolved
neonphog and others added 2 commits October 15, 2024 14:37
Co-authored-by: Callum Dunster <cdunster@users.noreply.github.com>
@neonphog neonphog requested a review from jost-s October 16, 2024 17:46
@neonphog neonphog merged commit b20d2cc into main Oct 16, 2024
7 checks passed
@neonphog neonphog deleted the mem-backend branch October 16, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants