-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mem backend for tx5 #106
mem backend for tx5 #106
Conversation
Co-authored-by: Callum Dunster <cdunster@users.noreply.github.com>
sweet, perhaps we can use this to finish up the tx2 removal in holochain? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments
/* | ||
* Mem backend timings. The hope is to have near ideal zero overhead. | ||
* At time of writing, you can see we're pretty close to exactly | ||
* proportional to node count for a given machine's resources: | ||
* | ||
* - 1 nodes, 33941 ops, 0.000028 sec/op, in 1.004478s | ||
* - 10 nodes, 174041 ops, 0.000056 sec/op, in 1.016977s | ||
* - 100 nodes, 175111 ops, 0.000580 sec/op, in 1.018943s | ||
* - 1000 nodes, 160266 ops, 0.006361 sec/op, in 1.019859s | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be a file-level comment block with //!
at the top?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, good call. done: 1887abd
// in base64 a string of 0xb7 renders as `t7e3t7e3t...` | ||
// which sort-of looks like "test" if you squint : ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😆
Co-authored-by: Callum Dunster <cdunster@users.noreply.github.com>
No description provided.