Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump lair_keystore_api #76

Merged
merged 2 commits into from
Dec 16, 2023
Merged

Conversation

jost-s
Copy link
Contributor

@jost-s jost-s commented Dec 15, 2023

Bumping lair_keystore_api in this package, because it doesn't allow 0.4.0 with the current version requirement and pulls in rmp-serde indirectly. Do you prefer >=0.3.0 or 0.4.0?
>=0.3.0 allows for anything greater or equal to 0.3.0, major, minor and patch
0.4.0 is >=0.4.0 and <0.5.0

@neonphog
Copy link
Collaborator

@jost-s - Not sure I have a strong opinion. Technically this time it's probably okay since the actual api didn't change, but if version 0.5 no longer compiles as-is, it's probably safer to use "0.4.0" right?

@jost-s
Copy link
Contributor Author

jost-s commented Dec 15, 2023

Yes, I agree.

@jost-s jost-s requested a review from neonphog December 15, 2023 22:02
@neonphog neonphog added this pull request to the merge queue Dec 16, 2023
Merged via the queue into main with commit f8dca63 Dec 16, 2023
6 checks passed
@neonphog neonphog deleted the build/bump-lair-keystore-api branch December 16, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants