feat: add run_with_required_agents function for TryCP scenarios #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdunster
force-pushed
the
add-required-number-of-agents
branch
2 times, most recently
from
e0f788a
to
701045f
Compare
cdunster
changed the title
|
@ThetaSinner, as per our discussion; I changed this to only be an option for TryCP scenarios instead of all scenarios. I'll drop the first two commits before merging to |
cdunster
force-pushed
the
add-required-number-of-agents
branch
from
701045f
to
33fd2a6
Compare
cdunster
commented
Oct 24, 2024
neonphog
reviewed
Oct 24, 2024
neonphog
reviewed
Oct 24, 2024
neonphog
previously approved these changes
Oct 25, 2024
This calls `run` and checks that it completes with at least the passed number of agents. This can be overridden via the `MIN_REQUIRED_AGENTS` environment variable.
cdunster
force-pushed
the
add-required-number-of-agents
branch
from
b6e589d
to
8851b54
Compare
ThetaSinner
reviewed
Oct 28, 2024
ThetaSinner
reviewed
Oct 28, 2024
cdunster
force-pushed
the
add-required-number-of-agents
branch
from
18757af
to
ee58fec
Compare
ThetaSinner
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The minimum number of required agents to run the scenario to completion. Can be overridden via an environment variable
MIN_REQUIRED_AGENTS.