Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/update versions #121

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Chore/update versions #121

wants to merge 5 commits into from

Conversation

ThetaSinner
Copy link
Member

No description provided.

@ThetaSinner ThetaSinner requested a review from a team October 28, 2024 13:16
Cargo.toml Show resolved Hide resolved
flake.nix Show resolved Hide resolved
flake.nix Show resolved Hide resolved
nix/modules/rust.nix Show resolved Hide resolved
framework/runner/src/monitor.rs Show resolved Hide resolved
@@ -1,6 +1,6 @@
[package]
name = "holochain_client_instrumented"
version = "0.3.0-alpha.1"
version = "0.4.0-alpha.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If these are always going to be the same then we could use a workspace version instead of defining it individually for each package.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do intend to allow these to move independently. If you change the framework then the bindings also need to move but the reverse isn't true. You can update the Rust client without changing the framework, or add a new common function that doesn't require internal changes. We just don't have proper releasing set up in here yet and I needed a quick script to get versions out when Holo wanted to use the library code :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants