Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single conductor scenarios #39

Merged
merged 21 commits into from
Jun 3, 2024
Merged

Single conductor scenarios #39

merged 21 commits into from
Jun 3, 2024

Conversation

ThetaSinner
Copy link
Member

@ThetaSinner ThetaSinner commented May 28, 2024

Single conductor scenarios from #2. Everything else will be going through trycp for now

@ThetaSinner ThetaSinner requested a review from a team May 30, 2024 10:10
neonphog
neonphog previously approved these changes May 30, 2024
Copy link
Contributor

@neonphog neonphog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visual inspection looks awesome to me. Let me know if you'd like me to go more in-depth and actually run the scenarios / look at the influx dashboards. If so I can retract my approval until I do that 👍

Co-authored-by: David Braden <neonphog@gmail.com>
@ThetaSinner
Copy link
Member Author

Thanks! I think it'll make sense at some point soon to run this on somebody else's machine. At that point I can walk through running the scenarios and review the dashboards as part of that

@ThetaSinner ThetaSinner added this pull request to the merge queue Jun 3, 2024
Merged via the queue into main with commit d4f4e57 Jun 3, 2024
1 check passed
@ThetaSinner ThetaSinner deleted the single-conductor-scenarios branch July 15, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants