Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation Receipts Scenario #83

Merged
merged 3 commits into from
Sep 3, 2024
Merged

Validation Receipts Scenario #83

merged 3 commits into from
Sep 3, 2024

Conversation

neonphog
Copy link
Contributor

@neonphog neonphog commented Aug 29, 2024

RESOLVES #44

validation_receipt_timing

Hehe ^^ I thought this graph was a little too awesome. It turns out it was breaking out of the loop early if it hadn't received any receipts at all yet. With that fixed, I'm seeing much more expected 3 to 6 second timing on this.


Graph now split by op type in "wait_for_complete" mode:

validation_receipts_wait_complete


New graph in "no_wait_for_complete" mode... much weirder graph that stops getting data part way through. I assume that is because a bunch of the actions never actually complete, especially as it goes on. But that can be something to figure out in another story:

validation_receipts_no_wait_complete

Copy link
Member

@ThetaSinner ThetaSinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I do have a few questions about this one but I'm open to any responses and I'd be happy that this adds great value as it is :)

Copy link
Member

@ThetaSinner ThetaSinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome!

@neonphog neonphog merged commit 103e4e4 into main Sep 3, 2024
2 checks passed
@neonphog neonphog deleted the v-rcpt branch September 3, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wind Tunnel Scenario: Time to receive required validation receipts
2 participants