Separate where combine_cpu functions by ndim #1265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1265 +/- ##
==========================================
+ Coverage 83.44% 83.47% +0.03%
==========================================
Files 35 35
Lines 9071 9089 +18
==========================================
+ Hits 7569 7587 +18
Misses 1502 1502
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jbednar
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This separates out the
wherereductioncombine_cpufunctions by number of array dimensions, which may be 2, 3 or 4 depending on whether they containcategoricaland/or a*_nselector reductions. This is the same as already done for thecombine_cudafunctions.