Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Remove Dask as a hard dependency of Datashader #1350

Merged
merged 15 commits into from
Nov 12, 2024
Merged

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Jul 3, 2024

Resolves #1349

Copy link
Member

@jbednar jbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, when we discussed this on Discord yesterday I thought this would go onto the backlog and never get done, but here it is already being addressed! What a nice feeling! Looks good so far; just what I'd expect to see.

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 63.28125% with 47 lines in your changes missing coverage. Please review.

Project coverage is 88.42%. Comparing base (e5182bf) to head (7e6e571).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
datashader/bundling.py 36.36% 7 Missing ⚠️
datashader/tests/test_raster.py 68.42% 6 Missing ⚠️
datashader/tiles.py 33.33% 6 Missing ⚠️
datashader/tests/test_transfer_functions.py 55.55% 4 Missing ⚠️
datashader/tests/test_xarray.py 60.00% 4 Missing ⚠️
datashader/core.py 75.00% 3 Missing ⚠️
datashader/resampling.py 66.66% 3 Missing ⚠️
datashader/tests/test_quadmesh.py 76.92% 3 Missing ⚠️
datashader/tests/test_dask.py 66.66% 2 Missing ⚠️
datashader/tests/test_geopandas.py 50.00% 2 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1350      +/-   ##
==========================================
- Coverage   88.59%   88.42%   -0.18%     
==========================================
  Files          93       93              
  Lines       18627    18707      +80     
==========================================
+ Hits        16503    16541      +38     
- Misses       2124     2166      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro
Copy link
Member Author

hoxbro commented Jul 4, 2024

@hoxbro hoxbro added this to the v0.17.0 milestone Jul 4, 2024
@hoxbro hoxbro marked this pull request as ready for review July 4, 2024 09:50
@hoxbro hoxbro requested a review from philippjfr August 18, 2024 14:45
@hoxbro hoxbro changed the title Remove Dask as a hard dependency of Datashader refactor!: Remove Dask as a hard dependency of Datashader Nov 11, 2024
Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you!

@hoxbro hoxbro enabled auto-merge (squash) November 12, 2024 12:10
@hoxbro hoxbro merged commit 1b9eac6 into main Nov 12, 2024
12 checks passed
@hoxbro hoxbro deleted the remove_dask_deps branch November 12, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Dask as a hard dependency of Datashader
3 participants