-
-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: Remove Dask as a hard dependency of Datashader #1350
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, when we discussed this on Discord yesterday I thought this would go onto the backlog and never get done, but here it is already being addressed! What a nice feeling! Looks good so far; just what I'd expect to see.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1350 +/- ##
==========================================
- Coverage 88.59% 88.42% -0.18%
==========================================
Files 93 93
Lines 18627 18707 +80
==========================================
+ Hits 16503 16541 +38
- Misses 2124 2166 +42 ☔ View full report in Codecov by Sentry. |
I can see we need to update HoloViews at least in one place: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thank you!
Resolves #1349