Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update widget error #515

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Fix update widget error #515

merged 1 commit into from
Jan 24, 2024

Conversation

ahuang11
Copy link
Contributor

@ahuang11 ahuang11 commented Dec 15, 2023

To start, I don't know if this is the ideal solution, but there's no more errors initially and the app works as expected.

The issue is that _update_data gets called before self._update_widget is set (so before init), but I have no idea how/why _update_data is getting called inside the super().__init__.

If I try to move

self._update_widget = pn.Param(self.param['update'], widgets={'update': {'button_type': 'success'}})[0]

before super().__init__, it complains about lumen.validation.ValidationError: '' table could not be found in Intake catalog.

@ahuang11 ahuang11 requested a review from philippjfr December 15, 2023 16:57
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2350515) 69.39% compared to head (e2529f4) 69.37%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #515      +/-   ##
==========================================
- Coverage   69.39%   69.37%   -0.02%     
==========================================
  Files          79       79              
  Lines        9190     9193       +3     
==========================================
+ Hits         6377     6378       +1     
- Misses       2813     2815       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 2521417 into main Jan 24, 2024
11 checks passed
@philippjfr philippjfr deleted the fix_update_widget_error branch January 24, 2024 10:03
ahuang11 added a commit that referenced this pull request Apr 18, 2024
Copy link

github-actions bot commented May 7, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants