Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix refreshing SQL after error #887

Merged
merged 2 commits into from
Dec 30, 2024
Merged

Fix refreshing SQL after error #887

merged 2 commits into from
Dec 30, 2024

Conversation

ahuang11
Copy link
Contributor

@ahuang11 ahuang11 commented Dec 20, 2024

Closes #886

Before (I change limit, yet it still sticks to 5)

bef.mp4

After (everything works as expected)

a.mp4

@ahuang11 ahuang11 requested a review from philippjfr December 20, 2024 19:44
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 51.65%. Comparing base (3b580de) to head (d373cd4).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
lumen/sources/duckdb.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #887      +/-   ##
==========================================
- Coverage   51.66%   51.65%   -0.01%     
==========================================
  Files         108      108              
  Lines       13697    13699       +2     
==========================================
  Hits         7076     7076              
- Misses       6621     6623       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit e07a065 into main Dec 30, 2024
12 checks passed
@philippjfr philippjfr deleted the fix_refresh_sql branch December 30, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After exception, future changes to the SQL doesn't update the exploration table
2 participants