Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename table #888

Closed
wants to merge 3 commits into from
Closed

Rename table #888

wants to merge 3 commits into from

Conversation

ahuang11
Copy link
Contributor

If user changes the query completely, the table name no longer is relevant

Not sure I like the idea of having an LLM in a view though.

@ahuang11 ahuang11 requested a review from philippjfr December 20, 2024 20:05
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 51.61%. Comparing base (3b580de) to head (d360387).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
lumen/ai/views.py 0.00% 7 Missing ⚠️
lumen/sources/duckdb.py 0.00% 4 Missing ⚠️
lumen/ai/models.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #888      +/-   ##
==========================================
- Coverage   51.66%   51.61%   -0.05%     
==========================================
  Files         108      108              
  Lines       13697    13708      +11     
==========================================
  Hits         7076     7076              
- Misses       6621     6632      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahuang11 ahuang11 closed this Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant