Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent empty explorations from crashing #912

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Conversation

ahuang11
Copy link
Contributor

@ahuang11 ahuang11 commented Jan 2, 2025

For a new user exploring the UI, randomly clicking on the tabs would crash the UI if they haven't input any message yet.

@ahuang11 ahuang11 requested a review from philippjfr January 2, 2025 21:51
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 56.85%. Comparing base (5d347d5) to head (dff8e38).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
lumen/ai/ui.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #912      +/-   ##
==========================================
- Coverage   56.86%   56.85%   -0.01%     
==========================================
  Files         108      108              
  Lines       13720    13722       +2     
==========================================
  Hits         7802     7802              
- Misses       5918     5920       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 34a7328 into main Jan 3, 2025
12 checks passed
@philippjfr philippjfr deleted the fix_empty_explorations branch January 3, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants