feat: add proxmox integration #1752
Conversation
|
Here's the code health analysis summary for commits Analysis Summary
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| export class ProxmoxIntegration extends Integration { | ||
| public async testConnectionAsync(): Promise<void> { | ||
| process.env.NODE_TLS_REJECT_UNAUTHORIZED = "0"; // TODO: Can we improve this? |
Check failure
Code scanning / CodeQL
Disabling certificate validation High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 14 days ago
To fix the problem, we need to ensure that TLS certificate validation is not disabled. Instead of setting process.env.NODE_TLS_REJECT_UNAUTHORIZED to "0", we should allow the default behavior of Node.js to validate certificates. If there is a need to handle self-signed certificates or certificates from a private CA, we should configure the application to trust those certificates explicitly.
The best way to fix this without changing existing functionality is to remove the line that sets process.env.NODE_TLS_REJECT_UNAUTHORIZED to "0". If necessary, we can add logic to handle custom certificates securely.
| @@ -7,3 +7,2 @@ | ||
| public async testConnectionAsync(): Promise<void> { | ||
| process.env.NODE_TLS_REJECT_UNAUTHORIZED = "0"; // TODO: Can we improve this? | ||
| const proxmox = this.getPromoxApi(); |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Homarr
Thank you for your contribution. Please ensure that your pull request meets the following pull request:
pnpm buid, autofix withpnpm format:fix)devbranchx,y,ior any abbrevation)