-
-
Notifications
You must be signed in to change notification settings - Fork 31.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump pybotvac to 0.0.25 #115435
Bump pybotvac to 0.0.25 #115435
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently my saved replies dont work, but please add a diff from one version to the other
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Also, @Santobert, this integration would benefit from using a coordinator because every entity is using the same call to update the state. I once wanted to add it but I dont have the device to test it, do you maybe have some time in the future to look at this? |
@joostlek Done, thank you. I may find time to do this, but honestly I don't see much use in it. Newer Neato devices no longer work with this integration and I expect the older devices to slowly die out until one day Neato disables the API. |
Keep in mind we currently do a request for every entity, so instead of requesting the same data for every integration it would cost them less if we only requested one time for every cycle. It would maybe help a bit. |
Breaking change
Proposed change
Bump pybotvac to fix a syntax warning with newer python versions: stianaske/pybotvac#85
See all changes here: stianaske/pybotvac@v0.0.24...v0.0.25
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: