Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there are two position conditions for covers:
which both include "is" at the end of the string.
This is meant to build a complete sentence in the automation editor but will break in translations.
The verb plus "above" or "below" need to be added using ICU strings in the frontend.
This is not yet implemented but will conflict with the hard-coded "is" above.
For example in German the complete sentence becomes:
"When die aktuelle Position von {entity_name} über 50 ist"
As you can see we need to place the "above 50" in between and the "ist" ("is") moves to the end.
These hard-coded sentences will prevent that.
Also note that for all other states like lights etc. these conditions never include "is".
So this is a single inconsistency.
Proposed change
Remove "is" from the end of both strings.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: