Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suez water: fetch historical data in statistics #131166

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Suez water: fetch historical data in statistics #131166

wants to merge 2 commits into from
+331 −12

Conversation

jb101010-2
Copy link
Contributor

@jb101010-2 jb101010-2 commented Nov 21, 2024 •
edited
Loading

Proposed change

Fetch all historical provided by suez into statistics.

Suez water provide historical daily data of water consumption, these changes fetch all the available data and insert it into statistics to make it available in energy dashboard.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @ooii, mind taking a look at this pull request as it has been labeled with an integration (suez_water) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of suez_water can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign suez_water Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@jb101010-2 jb101010-2 mentioned this pull request Nov 21, 2024
Open
8 tasks
@jb101010-2 jb101010-2 marked this pull request as ready for review November 21, 2024 13:07
joostlek
joostlek requested changes Nov 22, 2024
View reviewed changes
tests/components/suez_water/test_sensor.py Outdated
with (
patch("homeassistant.components.suez_water.PLATFORMS", [Platform.SENSOR]),
patch(
"homeassistant.components.suez_water.coordinator.SuezWaterCoordinator._update_statistics",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we patch this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did it so each platform is tested indepently from each other but beaucse the statistics did not belong to any platform I did not find another way of doing it.

But I removed this patch anyway

tests/components/suez_water/test_statistics.py Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should rather go in test_init as we have tests per platform and we don't want to assume you are using a coordinator

tests/components/suez_water/test_statistics.py Outdated
_sum = 0
for _k, stat in enumerate(stats[statistic_id]):
value = 500
if statistic == "water_cost_statistics":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not have if statements in tests though

@home-assistant home-assistant bot marked this pull request as draft November 22, 2024 09:17
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@jb101010-2 jb101010-2 marked this pull request as ready for review November 22, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joostlek joostlek Awaiting requested review from joostlek

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
by-code-owner cla-signed has-tests integration: suez_water new-feature Quality Scale: No score
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

suez_water doesn't implement state_class
2 participants
@jb101010-2 @joostlek