-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update two strings for creating a Utility meter Helper #131196
base: dev
Are you sure you want to change the base?
Conversation
Anything the user creates in Home Assistant should use "Create …", not "Add …". This fixes the headline and makes it consistent with the description just below it. "Energy" covers "Gas" and "Heating" as well, what's meant here is "Electricity", changes this for proper translations, too.
Hey there @dgomes, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anything the user creates in Home Assistant should use "Create …", not "Add …".
Based on?
Please note, this adds an integration... which we call "add" everywhere.
"Energy" covers "Gas" and "Heating" as well, what's meant here is "Electricity".
Incorrect. The use of this integration is not limited to electricity (although a common use case).
../Frenck
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
@frenck It's part of the Home Assistant Design guidelines The line "Create Utility Meter" is the headline of the Helper this creates. It is not related to adding the integration. You misunderstood my explanation regarding "energy" vs. "electricity": The suggested change does not remove "gas" and "heating", it just changes "energy" into "electricity" as this is what you get from your utility. Energy is the overarching term, the meters are for electricity, gas, district heating (or water). See the string below the headline in the screenshot. |
I've updated the complete description of the PR to avoid all the misunderstandings I created by keeping this too short. Was a bit of marathon for me today and on the last miles I started to fail … |
Anything the user creates in Home Assistant should use "Create …", not "Add …" following the Home Assistant Design guidelines .
The Utility Meter helper is one of the few remaining Helper types that still uses "Add":
In the description above in the screen shot "energy" is used to refer to electricity. But "energy" covers "gas" and "heating" as well, so this is misleading.
Therefore it should say "electricity, gas, water and heating" instead.
Changing this for consistency with translations, too:
For example in German we'd definitely say "Strom" (electricity) here.
Proposed change
Replace "Add" with "Create" in the headline.
Replace "energy" with "electricity" in the description.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: