Add weather warning sensor to IPMA #134054
Conversation
| return self._ipma_data | ||
|
|
||
| @property | ||
| def extra_state_attributes(self) -> dict[str, Any] | None: |
There was a problem hiding this comment.
Extra attributes are not great as they are persisted along the state.
Isn't it possible to store them as other sensors? Possibly disabled by default?
There was a problem hiding this comment.
I would agree with that, if it was not for existing integrations that follow this pattern (e.g. meteo-france). And for cards such as https://github.com/MrBartusek/MeteoalarmCard.
Truth be told the extra attributes are actually part of the state, it's just a desegregation of the state.
There was a problem hiding this comment.
I was afraid of that, and it kind ok make sense to have all the related data together.
I tried 😄
| def extra_state_attributes(self) -> dict[str, Any] | None: | ||
| """Return the state attributes.""" | ||
| if ( | ||
| self.entity_description.value_extractor is not None |
There was a problem hiding this comment.
In my opinion, this feels a bit like a hack , I'd find it cleaner to have a function in entity description to extract the attributes.
There was a problem hiding this comment.
It does indeed, but the issue is the API provides all the information (state and extra-attributes) in a single request and I must split that information into state and extra-attributes.
There was a problem hiding this comment.
I understood that part, that's why I suggested the second version.
Add another function in IPMASensorEntityDescription to extract the attributes and use it instead of using something which might not be related
class IPMASensorEntityDescription(SensorEntityDescription):
"""Describes a IPMA sensor entity."""
....
extra_attr_fn: Callable[[Any], dict[str, Any]] | None = None
|
|
||
| state = hass.states.get("sensor.hometown_weather_alert") | ||
|
|
||
| assert state.state == "yellow" |
There was a problem hiding this comment.
If extra states are present they should be asserted for
| async def test_ipma_warning_create_sensors(hass: HomeAssistant) -> None: | ||
| """Test creation of warning sensors.""" | ||
|
|
||
| with patch("pyipma.location.Location.get", return_value=MockLocation()): |
There was a problem hiding this comment.
IMO it is also a good practice to test failing case.
Exceptions if any and in your case the fact that the data could not be present.
Proposed change
Adds a new sensor, providing weather warnings.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: