Support SELECT_SOURCE for Bose soundtouch #31071

zhumuht · 2020-01-22T06:20:09Z

Breaking change

Proposed change

support SELECT_SOURCE for Bose soundtouch, and show friendly_name

Type of change

New feature (which adds functionality to an existing integration)

Example entry for `configuration.yaml`:

media_player:
  - platform: soundtouch
    host: 192.168.100.99
    name: bose_soundtouch_083944
    resources:
      - name: "BluRayPlayer"
        source: "HDMI_3"
      - name: "XBox360"
        source: "HDMI_1"
      - name: "TMall Box"
        source: "HDMI_4"

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request:

Checklist

The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
The code has been formatted using Black (black --fast homeassistant tests)
Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

No score or internal
🥈 Silver
🥇 Gold
🏆 Platinum

homeassistant/components/soundtouch/const.py

homeassistant/components/soundtouch/media_player.py

MartinHjelmare · 2020-01-22T08:59:01Z

homeassistant/components/soundtouch/media_player.py

@@ -78,11 +83,16 @@
 | SUPPORT_PLAY_MEDIA
 )

+SOURCE_SCHEMA = vol.Schema(
+ {vol.Required(CONF_SOURCE): cv.string, vol.Required(CONF_NAME): cv.string}


Please check that the source is one of the supported sources of the library.

https://github.com/CharlesBlonde/libsoundtouch , this library is not updated 2 years. no api to check source

We have the enum Source available from the library. Can't we use that?

HDMI_1 ~ HDMI_6, and something else, not belong to source, but sourceAccount.
sourceAccount not enum in the library.

sources from device:

MartinHjelmare · 2020-01-22T09:00:05Z

homeassistant/components/soundtouch/media_player.py

 PLATFORM_SCHEMA = PLATFORM_SCHEMA.extend(
 {
 vol.Required(CONF_HOST): cv.string,
 vol.Optional(CONF_NAME, default=DEFAULT_NAME): cv.string,
 vol.Optional(CONF_PORT, default=DEFAULT_PORT): cv.port,
+ vol.Optional(CONF_RESOURCES): vol.All(cv.ensure_list, [SOURCE_SCHEMA]),


Why do we need this option? If we know what the device supports, we can just return that list of sources in the media player entity source list.

https://github.com/CharlesBlonde/libsoundtouch , this library is not updated 2 years. no api to get sources that device supported.
so config sources to configuration.yaml

would it make sense to bump libsoundtouch to 0.8.0 since HA is currently using an even older version?

btw - this might be an alternative in future? Just found it https://github.com/trunet/aiobosest

We like asyncio! If that works it might be a very nice replacement! The repo looks a bit dormant though.

would it make sense to bump libsoundtouch to 0.8.0 since HA is currently using an even older version?

in this pr, libsoundtouch lib already be updated to 0.8.0

Since the sources could be fetched from the api if the library would support it, I don't think adding this config option is a good step forward. We want to avoid config options as much as possible.

Please update or change library first, in a separate PR, and then we see if this PR is still needed.

there is a pending PR over at libsoundtouch which would add a source list, but the maintainer didn't respond to PRs in over a year. CharlesBlonde/libsoundtouch#34

The repo looks a bit dormant though.

Yes, the author of it commented that he wrote it for HA back then but the guys implementing the HA component went with libsoundtouch instead, which is why he stopped working on it. But he seems to be interested in working on it and implement the missing features if we (HA) considers to switch to it.
CharlesBlonde/libsoundtouch#38

I'm not saying we have to or should, especially since libsoundtouch is well documented and it's always a pitty if well used projects either have to be forked or abandoned.

If the maintainer of https://github.com/trunet/aiobosest is active and the maintainer of https://github.com/CharlesBlonde/libsoundtouch is not, I suggest we change to the active library.

homeassistant/components/soundtouch/media_player.py

stale · 2020-03-21T17:27:33Z

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

homeassistant added the cla-signed label Jan 22, 2020

probot-home-assistant bot added the integration: soundtouch label Jan 22, 2020

zhumuht requested a review from MartinHjelmare January 22, 2020 06:20

zhumuht force-pushed the soundtouch_source branch 2 times, most recently from 68cec0d to 8b3f053 Compare January 22, 2020 08:22

MartinHjelmare changed the title ~~support SELECT_SOURCE for Bose soundtouch~~ Support SELECT_SOURCE for Bose soundtouch Jan 22, 2020

MartinHjelmare requested changes Jan 22, 2020

View reviewed changes

zhumuht added 2 commits January 22, 2020 19:19

support soundtouch source

dbde5e5

remove debug log

4ebb762

zhumuht force-pushed the soundtouch_source branch from c6105f4 to bce70a4 Compare January 22, 2020 11:29

modify for review soundtouch

2ec7c43

zhumuht force-pushed the soundtouch_source branch from d3155b5 to 2ec7c43 Compare January 22, 2020 12:32

soundtouch resources,use dict[key]

9fddf35

MartinHjelmare mentioned this pull request Feb 13, 2020

Implement soundtouch select source #31669

Merged

20 tasks

stale bot added the stale label Mar 21, 2020

stale bot closed this Mar 28, 2020

da-anda mentioned this pull request Apr 1, 2020

Add select source to soundtouch #33490

Closed

20 tasks

lock bot locked and limited conversation to collaborators Apr 2, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support SELECT_SOURCE for Bose soundtouch #31071

Support SELECT_SOURCE for Bose soundtouch #31071

zhumuht commented Jan 22, 2020

MartinHjelmare Jan 22, 2020

zhumuht Jan 22, 2020

MartinHjelmare Jan 22, 2020

zhumuht Jan 23, 2020

MartinHjelmare Jan 22, 2020

zhumuht Jan 22, 2020

da-anda Jan 22, 2020

da-anda Jan 22, 2020

MartinHjelmare Jan 22, 2020

zhumuht Jan 23, 2020

MartinHjelmare Jan 23, 2020

da-anda Jan 23, 2020 •

edited

Loading

MartinHjelmare Jan 23, 2020 •

edited

Loading

stale bot commented Mar 21, 2020

Support SELECT_SOURCE for Bose soundtouch #31071

Support SELECT_SOURCE for Bose soundtouch #31071

Conversation

zhumuht commented Jan 22, 2020

Breaking change

Proposed change

Type of change

Example entry for configuration.yaml:

Additional information

Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

da-anda Jan 23, 2020 • edited Loading

Choose a reason for hiding this comment

MartinHjelmare Jan 23, 2020 • edited Loading

Choose a reason for hiding this comment

stale bot commented Mar 21, 2020

Example entry for `configuration.yaml`:

da-anda Jan 23, 2020 •

edited

Loading

MartinHjelmare Jan 23, 2020 •

edited

Loading