Landing page #22598
Landing page #22598
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| import { fireEvent } from "../../../src/common/dom/fire_event"; | ||
| import { fileDownload } from "../../../src/util/file_download"; | ||
|
|
||
| const ERROR_CHECK = /^[\d -:]+(ERROR|CRITICAL)(.*)/gm; |
Check warning
Code scanning / CodeQL
Overly permissive regular expression range Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 11 days ago
To fix the problem, we need to make the regular expression more explicit and avoid overlapping character ranges. Instead of using \d and -: in the same character class, we can list the specific characters we want to match. This will ensure that the regular expression only matches the intended characters and avoids any unintended overlaps.
The best way to fix the problem without changing existing functionality is to replace the character class [\d -:] with a more explicit character class that includes digits, space, hyphen, and colon. We can use [0-9 :\-] to achieve this.
| @@ -21,3 +21,3 @@ | ||
|
|
||
| const ERROR_CHECK = /^[\d -:]+(ERROR|CRITICAL)(.*)/gm; | ||
| const ERROR_CHECK = /^[0-9 :\-]+(ERROR|CRITICAL)(.*)/gm; | ||
| declare global { |
build-scripts/gulp/compress.js
Outdated
|
|
||
| gulp.task("compress-app", gulp.parallel(compressAppBrotli, compressAppZopfli)); | ||
| gulp.task( | ||
| "compress-hassio", | ||
| gulp.parallel(compressHassioBrotli, compressHassioZopfli) | ||
| ); | ||
| gulp.task( | ||
| "compress-landing-page", | ||
| gulp.parallel(compressLandingPageBrotli, compressLandingPageZopfli) |
There was a problem hiding this comment.
Does the go web server we use support this?
There was a problem hiding this comment.
🤷 Just did the same as hassio build, I will test it out.
There was a problem hiding this comment.
No it doesn't support this, just with 3rd party libs. I will remove it from the build.
Proposed change
Add landing page frontend project
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: