-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for Debian 11 Bullseye #5335
Conversation
📝 WalkthroughWalkthroughThe changes involve an update to the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
supervisor/resolution/evaluations/operating_system.py (1)
Line range hint
33-36
: Consider updating documentation and user messagesThe change to
SUPPORTED_OS
will cause theevaluate
method to flag any OS other than Debian 12 (bookworm) as unsupported. While this is consistent with the PR objectives, it's important to ensure that:
- Any relevant documentation is updated to reflect this change in supported operating systems.
- User-facing messages (like the one in the
on_failure
property) clearly communicate that only Debian 12 is now supported.This will help prevent confusion for users who may still be using Debian 11 or other operating systems.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- supervisor/resolution/evaluations/operating_system.py (1 hunks)
🧰 Additional context used
🔇 Additional comments (1)
supervisor/resolution/evaluations/operating_system.py (1)
8-8
: LGTM: Change aligns with PR objectivesThe modification to
SUPPORTED_OS
correctly implements the PR objective to drop support for Debian 11 Bullseye. This change is straightforward and aligns well with the provided PR summary.
Proposed change
I think now is the time to drop support for Debian Bullseye, I held off because of the privilege issues we were having in the past but I have not seen any issues pop up recently in regards to that and in my own testing it seems it has been solved by home-assistant/version#370, #4381 and home-assistant/version#372. Thus I am now comfortable with dropping Debian 11 Bullseye
Type of change
Additional information
Checklist
ruff format supervisor tests
)If API endpoints or add-on configuration are added/changed:
Summary by CodeRabbit
New Features
Bug Fixes