Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add "uncheck" prop to HdRadio #1012

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

limhenry
Copy link
Contributor

@limhenry limhenry commented Aug 17, 2022

Details

Allow user to uncheck the radio button:

Screen.Recording.2022-08-17.at.10.25.37.AM.mov

Related Ticket

https://homeday.atlassian.net/browse/VIEW-970

Preview

https://frontend-pulls.homeday.de/homeday-blocks/1012/ (Form > HdRadio > Uncheck)

Major Changes

  • ✨ Added "uncheck" prop to HdRadio

@github-actions
Copy link

🚀 This PR has been deployed here: https://frontend-pulls.homeday.de/homeday-blocks/1012/

@limhenry limhenry marked this pull request as ready for review August 17, 2022 08:40
@limhenry limhenry requested a review from a user August 17, 2022 08:40
Copy link
Contributor

@SusCasasola SusCasasola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, but it makes me wonder if we should uncheck the radio buttons as we are modifying their default behaviour, shouldn't we use a checkbox instead? or may be a "none of the above" options? I am curious about the specific cases where we could use this

@limhenry
Copy link
Contributor Author

@SusCasasola

  • checkbox: no? because user can select one option only
  • "none of the above": um ... sounds like a possible solution? lemme check with the designer
  • the biggest problem is this form (sliders) is "optional", so user can proceed without select any option

image

@SusCasasola
Copy link
Contributor

  • the biggest problem is this form (sliders) is "optional", so user can proceed without select any option

Aah I see! thanks for the quick answer. If the problem is that the selection should be optional, then we can suggest using a "none of the above" option.

I wonder what do the rest of the team thinks about it? @homeday-de/frontend-engineering

I have never asked myself this, so I searched for information and here is what I found: https://ux.stackexchange.com/questions/13511/why-is-it-impossible-to-deselect-html-radio-inputs

@limhenry limhenry marked this pull request as draft August 19, 2022 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants