Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: cleanup release #250

Merged
merged 2 commits into from
May 23, 2023
Merged

maint: cleanup release #250

merged 2 commits into from
May 23, 2023

Conversation

TylerHelmuth
Copy link
Contributor

Which problem is this PR solving?

With the bump to chart releaser 1.5.0 we lost the ability to do cr index with an ssh git remote; the tool now requires us to use an https remote. For the v1.2.3-secure-tenancy release I had to do the cr index step manually from my laptop. See and helm/chart-releaser#124.

The PR solves this problem and also removes some deprecated flags and unused env vars.

Short description of the changes

  • set git remote to https url for cr index step.
  • remove unused --charts-repo flag
  • remove unused variables.

How to verify that this has the expected result

I couldn't :/ but I'll try to do a honeycomb chart release once this is merged to test it.

@TylerHelmuth TylerHelmuth requested a review from a team as a code owner May 12, 2023 22:15
Copy link
Contributor

@kentquirk kentquirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@TylerHelmuth TylerHelmuth merged commit f96e8d6 into main May 23, 2023
@TylerHelmuth TylerHelmuth deleted the tyler/cleanup-release branch May 23, 2023 19:10
@TylerHelmuth TylerHelmuth mentioned this pull request May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants