Skip to content

Commit

Permalink
maint: Replace HNY baggage span procesor with published BaggageActivi…
Browse files Browse the repository at this point in the history
…tyProcessor
  • Loading branch information
MikeGoldsmith committed Apr 25, 2024
1 parent 2c06cee commit 49c6a3e
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 24 deletions.
21 changes: 0 additions & 21 deletions src/Honeycomb.OpenTelemetry/BaggageSpanProcessor.cs

This file was deleted.

1 change: 1 addition & 0 deletions src/Honeycomb.OpenTelemetry/Honeycomb.OpenTelemetry.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="All" />
<PackageReference Include="Microsoft.Extensions.Configuration.CommandLine" Version="7.0.0" />
<PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="7.0.0" />
<PackageReference Include="OpenTelemetry.Extensions" Version="1.0.0-beta.4" />
<PackageReference Include="System.Runtime.InteropServices" Version="4.3.0" />
<PackageReference Include="System.Runtime.InteropServices.RuntimeInformation" Version="4.3.0" />
<PackageReference Include="System.Text.Json" Version="7.0.3" />
Expand Down
2 changes: 1 addition & 1 deletion src/Honeycomb.OpenTelemetry/HoneycombOptions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ internal static bool IsClassicKey(string apikey)
public ResourceBuilder ResourceBuilder { get; set; } = ResourceBuilder.CreateDefault();

/// <summary>
/// Determines whether the <see cref="BaggageSpanProcessor"/> is added when configuring a <see cref="TracerProviderBuilder"/>.
/// Determines whether the <see cref="BaggageActivityProcessor"/> is added when configuring a <see cref="TracerProviderBuilder"/>.
/// </summary>
public bool AddBaggageSpanProcessor { get; set; } = true;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -121,11 +121,11 @@ public static TracerProviderBuilder AddHoneycomb(this TracerProviderBuilder buil
}

/// <summary>
/// Configures the <see cref="TracerProviderBuilder"/> to add the <see cref="BaggageSpanProcessor"/> span processor.
/// Configures the <see cref="TracerProviderBuilder"/> to add the <see cref="BaggageActivityProcessor"/> span processor.
/// </summary>
public static TracerProviderBuilder AddBaggageSpanProcessor(this TracerProviderBuilder builder)
{
return builder.AddProcessor(new BaggageSpanProcessor());
return builder.AddProcessor(new BaggageActivityProcessor());
}

/// <summary>
Expand Down

0 comments on commit 49c6a3e

Please sign in to comment.