-
-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(adapter/alibaba-cloud-fc3): add alibaba cloud function compute 3.0 adapater support #3641
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3641 +/- ##
==========================================
+ Coverage 89.80% 91.72% +1.92%
==========================================
Files 159 161 +2
Lines 10120 10199 +79
Branches 2793 2919 +126
==========================================
+ Hits 9088 9355 +267
+ Misses 1032 842 -190
- Partials 0 2 +2 ☔ View full report in Codecov by Sentry. |
Maybe change |
The renaming and runtime test are complete. Could you please review and let me know if there’s anything else that needs to be adjusted? Thanks! |
Hi @rwv It's hard to decide if we should accept this PR because it's possible that no one can maintain this adapter. At least, I don't know much about Aliyun Function Compute. You may be able to maintain it, but that may not be possible in the future, and it will be hard for me to maintain it. |
Hi, Thank you for considering this PR. I understand the concern regarding long-term maintenance, especially since Aliyun Function Compute might not be widely familiar to the core team. I’d be glad to help maintain this adapter for as long as possible. Additionally, I’ve achieved 100% test coverage on this adapter, which should help with ensuring stability and making future maintenance easier. I can also provide documentation and implementation details to further support the team. If there are any specific concerns or suggestions, please let me know, and I’d be happy to address them. |
The author should do the following, if applicable
bun run format:fix && bun run lint:fix
to format the codeDocs
https://www.alibabacloud.com/help/en/functioncompute/fc-3-0/
Tests
src/adapter/aliyun-fc3/handler.test.ts
Differences with Hono's Getting Started with Aliyun Function Compute
The primary difference between this adapter and the setup described in Hono's official documentation lies in the deployment method for Alibaba Cloud Function Compute (FC).
Debian Docker Container (Hono Documentation): The official guide provides a setup using a Debian-based Docker container to deploy Hono applications on Aliyun FC. This approach involves creating a custom Docker environment that packages and runs the application, offering flexibility with OS-level configurations.
Native Node.js Environment (This Adapter): In contrast, this adapter uses Alibaba Cloud's Node.js runtime environment directly, similar to AWS Lambda. It leverages Alibaba Cloud FC's built-in Node.js support, bypassing the need for a custom Docker container. This approach simplifies deployment by focusing on function code rather than container management, making it faster to set up and closer in experience to other serverless platforms like AWS Lambda.