Handle dtyp's dependency to other dtyps #71
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've noticed this patch seems incomplete, so I'll close this PR and submit another later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Made
RDTyp.depsfrom a vector to a hashmap.DTypeNameIteratorto iterate over free occurrences of data types (same implementation as the originalmentions_dtyp).mentions_dtypto useDTypeNameIterator.Brief Description
Currently, there is no proper handling of
RDTyp.depssince theadd_depmethod isn't used. This field is crucial for HoIce when dumping terms that include data types, particularly in cases of mutually recursive data types. Without it, the current implementation incorrectly outputs SMT2 queries, leading to failures.